Skip to content

Conversation

@joe0BAB
Copy link
Contributor

@joe0BAB joe0BAB commented Sep 10, 2025

Description

We have removed the paywall on docker debug.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 7132e98
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/68c13f3075d4670008d5ec64
😎 Deploy Preview https://deploy-preview-23386--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joe0BAB, do we need to say that version 4.46 and below still need a subscription?

@aevesdocker aevesdocker added this to the DD4.46 milestone Sep 10, 2025
@joe0BAB
Copy link
Contributor Author

joe0BAB commented Sep 10, 2025

As of DD 4.46 release, this feature no longer requires any subscription. I assumed my change would remove that hint that we currently show (this thing shown in the screenshot is no longer needed as of 4.46)
image

@aevesdocker
Copy link
Contributor

aevesdocker commented Sep 10, 2025

yeh your change works in the preview. My question was more about is this change backward compatible. So if a user is on 4.45 or 4.44 etc, will they still need a subscription to use Docker Debug? if so, we need to adapt the info further.

I realise my initial phrasing was confusing. I meant versions below 4.46

@joe0BAB joe0BAB requested a review from aevesdocker September 10, 2025 09:33
@joe0BAB
Copy link
Contributor Author

joe0BAB commented Sep 10, 2025

Ah right, yes for 4.33 - 4.45 a subscription is needed. Do we have any standard way to express this? Or should I just adjust the sentence in requires to say this?

@aevesdocker
Copy link
Contributor

aevesdocker commented Sep 10, 2025

Yes, I think the simplest is just to add in the requires field "Docker Desktop 4.46 and later. For Docker Desktop versions 4.45.0 and earlier, you must have a Pro, Team, or Business subscription"

@aevesdocker
Copy link
Contributor

Closing PR as this change was rolled back last min.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants