-
Notifications
You must be signed in to change notification settings - Fork 8k
feat: Docker Debug no longer requires a subscription #23564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Follow up from #23386 |
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey @joe0BAB, I checked with Colin before the 4.48 release that this was to be announced with 4.49 with release notes and everything. |
|
yes, that was the initial plan, but it already got shipped with 4.48 (we also missed that in the 4.48 release notes, maybe we want to change them as well) |
|
@aevesdocker Do you see any issue with just updating the docs, to correctly represent the technical state of things? It's ok to have a distinct or decoupled marketing push that we sync with a 4.49. release. Also, this repo is public, so it's all out in the open already after all 😃 Maybe it helps if @colinhemmings confirms that it's fine to update the docs? |
|
More than happy to publish this now @kiview if that's what you want. But we can make a bigger 'splash' of it if we postpone to 4.49 as we can also have the release highlights within Desktop advertise this. In the past, when features have been released before widely advertised, we've just postponed publishing any docs updates to keep everything in sync and cheekily adjusted the version needed. We can do the same here. Let me know |
|
@kiview @joe0BAB @colinhemmings What's the plan? Merge now or postpone to 4.49? |
|
Let's merge! |
<!--Delete sections as needed --> ## Description Fixes #23564 As agreed with @colinhemmings we need to align docs with the release notes and highlights ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
Description
We have removed the paywall on docker debug. It's shipped in DD 4.48.
Related issues or tickets
Reviews