update nav dropdown behavior #23436
Merged
update nav dropdown behavior #23436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
usha-mandya
approved these changes
Sep 22, 2025
Member
usha-mandya
left a comment
usha-mandya
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change how the section drop-down arrows are rendered in the side-nav.
Currently, they generate for any folder, even if it just contains an index. To not generate the arrow, the index would have to be taken out of the folder and renamed as the folder.
This change now counts how many children under the index, and only generates the arrow if it has children (that aren't hidden from the nav).
For example, see how there is an arrow for the mcp gateway, but it expands to nothing.
Current: https://docs.docker.com/ai/mcp-gateway/
Updated: https://deploy-preview-23436--docsdocker.netlify.app/ai/mcp-gateway/
Related issues or tickets
Reviews