-
Notifications
You must be signed in to change notification settings - Fork 8.1k
docs: Add a section in the Bun guide to use DHI #23565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add a section in the Bun guide to use DHI #23565
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey, @usha-mandya. Great call. I have updated the docs. Thanks for the review! |
craig-osterhout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Pradumnasaraf. One small issue noted. Everything else appears to work smoothly.
|
Ah, good spot, @craig-osterhout. Yes, we can't have |
|
@Pradumnasaraf The updates aren't displayed in the deploy preview - https://deploy-preview-23565--docsdocker.netlify.app/guides/bun/. Not sure if I'm missing something. Could you PTAL? |
119b95b to
8a75d12
Compare
|
Hey @usha-mandya, for some reason, the preview did not get triggered. I have combined all the commits and pushed it (to trigger the preview again). Now you will be able to see it https://deploy-preview-23565--docsdocker.netlify.app/guides/bun/containerize/ |
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
Removed mention of Docker Hardened Images (DHI) from the guide description.
craig-osterhout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add a section in the Bun guide to use DHI
Reviews