engine: 29.3.0#24277
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR adds Docker Engine 29.3.0 release notes with comprehensive documentation of new features, bug fixes, and API changes. The content is well-structured, factually consistent, and follows the established format for release notes.
Minor Issue Found
One minor typo was detected that should be corrected:
Line 38: Extra period in API version string - "from v1.44. to v1.40" should be "from v1.44 to v1.40"
Other observations:
- Several lines exceed 80 characters in the source (lines with long links), but this is acceptable for release notes with inline reference links
- The release date (2026-03-05) follows the chronological pattern of version 29.x releases and appears intentional
Recommendation
Approve after correcting the typo on line 38. The documentation is otherwise ready for merge.
|
|
||
| ### Packaging updates | ||
|
|
||
| - Update BuildKit to [v0.28.0](https://github.com/moby/buildkit/releases/tag/v0.28.0). [moby/moby#52135](https://github.com/moby/moby/pull/52135) |
There was a problem hiding this comment.
Maybe @crazy-max has suggestions for something in the "new" section that comes with the BuildKit update? (We added the Identity support etc)?
There was a problem hiding this comment.
I think the one in API section for images/json is enough imo.
thaJeztah
left a comment
There was a problem hiding this comment.
one minor nit; LGTM otherwise
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
| - The `--gpus` option now uses CDI-based injection for AMD GPUs. [moby/moby#52048](https://github.com/moby/moby/pull/52048) | ||
| - Add `sd_notify` ["RELOADING"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#RELOADING=1) notifications when signalling the daemon to reload its configuration. [moby/moby#52041](https://github.com/moby/moby/pull/52041) | ||
| - Send sd\_notify ["READY"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#READY=1) and ["STOPPING"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#STOPPING=1) synchronously to make sure they are sent before we proceed. [moby/moby#52041](https://github.com/moby/moby/pull/52041) | ||
| - Add support for the systemd 253 `Type=notify-reload` service reload protocol. [moby/moby#52041](https://github.com/moby/moby/pull/52041) |
There was a problem hiding this comment.
isn't this a duplicate of the previous two?
There was a problem hiding this comment.
I guess the intent was to mark this as different features, that just happen to be made through single PR.
|
|
||
| - The `--gpus` option now uses CDI-based injection for AMD GPUs. [moby/moby#52048](https://github.com/moby/moby/pull/52048) | ||
| - Add `sd_notify` ["RELOADING"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#RELOADING=1) notifications when signalling the daemon to reload its configuration. [moby/moby#52041](https://github.com/moby/moby/pull/52041) | ||
| - Send `sd_notify` ["READY"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#READY=1) and ["STOPPING"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#STOPPING=1) synchronously to make sure they are sent before we proceed. [moby/moby#52041](https://github.com/moby/moby/pull/52041) |
There was a problem hiding this comment.
what are "they" and "we" in this context?
There was a problem hiding this comment.
We - daemon, they - "READY" and "STOPPING" assignments.
Description
Related issues or tickets
Reviews