Fix misleading HTTPS_PROXY wording and example URLs#24719
Conversation
Clarify that HTTPS_PROXY specifies the proxy for HTTPS requests, not that the proxy itself uses HTTPS. Change example URLs from https://proxy.example.com:3129 to http://proxy.example.com:3128 since most proxies accept HTTP connections and use CONNECT tunneling for HTTPS traffic. Also fix "non-HTTPS and a HTTPs proxy" casing. Fixes docker#20817 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR successfully fixes misleading HTTPS_PROXY documentation. The changes are technically accurate and improve clarity:
Technical accuracy: ✅ Correctly changes HTTPS_PROXY URLs from https:// to http:// - most proxies accept HTTP connections and use CONNECT tunneling for HTTPS traffic
Clarity improvement: ✅ Changes "If you are behind an HTTPS proxy server" to "To proxy HTTPS requests" - correctly clarifies that HTTPS_PROXY handles proxying of HTTPS traffic, not that the proxy itself uses HTTPS
Grammar fix: ✅ Fixes "non-HTTPS and a HTTPs proxy" to "an HTTP and an HTTPS proxy"
Consistency: ✅ Applied uniformly across both Regular install and Rootless mode tabs
Formatting: ✅ Removes extraneous blank line in NO_PROXY section
No issues found. The changes align with the style guide and accurately address issue #20817.
2 participants
Summary
HTTPS_PROXYspecifies the proxy for HTTPS requests, not that the proxy itself uses HTTPShttps://proxy.example.com:3129tohttp://proxy.example.com:3128since most proxies accept HTTP connections and use CONNECT tunneling for HTTPS trafficFixes #20817
🤖 Generated with Claude Code