Merged
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
craig-osterhout
approved these changes
Apr 17, 2026
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
LGTM.
One suggestion for existing content that's not necessary.
|
|
||
| When you add members to teams, you can grant additional repository permissions | ||
| You can grant repository permissions to members | ||
| beyond their organization role: |
Contributor
There was a problem hiding this comment.
For some reason, my brain short-circuited on this part and it took me a while to understand what it was trying to convey. I'm guessing it's just saying there are 2 different permission checks. Maybe provide an example or some flow diagram of permission checks for different combinations of each.
Contributor
Author
There was a problem hiding this comment.
I'm going to leave this as is but I've added it to a to do list for when I do a freshness sweep on this part of the admin docs. It's a good callout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs request from channel