docs: replace misleading Compose lifecycle hook examples#24866
Open
lacatoire wants to merge 2 commits intodocker:mainfrom
Open
docs: replace misleading Compose lifecycle hook examples#24866lacatoire wants to merge 2 commits intodocker:mainfrom
lacatoire wants to merge 2 commits intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
post_startexample (chowning a volume so the app can use it) and thepre_stopexample (flushing caches) don't survive a careful read: the post_start hook runs in parallel with the entrypoint so it cannot reliably prepare the filesystem before the app reads it, and pre_stop doesn't run on abrupt termination so it's the wrong place to flush state the application should already flush on a graceful stop.Replace both examples with cases that match the documented hook semantics (external registration on start, external de-registration on stop), and add a short caveat explaining why the previous patterns were wrong to attempt.
Fixes #24853