Skip to content

Conversation

@pav-alekseev
Copy link

Proposed changes

This tutorial uses the old apt-get command. This commit updates that command to the new command apt.

@GordonTheTurtle
Copy link

Deploy preview for docsdocker ready!

Built with commit 17cf632

https://deploy-preview-8135--docsdocker.netlify.com

@ghost ghost requested a review from thaJeztah February 4, 2019 15:15
Copy link
Contributor

@bermudezmt bermudezmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaJeztah since the apt command is becoming more popular as a package manager, should we update our instructions with a note that apt-get is still more stable and more suitable for use in automation? I wanted to hear your thoughts.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall we held off this change in the past, due to apt not always showing the same behavior between distro versions, but perhaps it's stable enough now (and some older distro versions are no longer supported).

If we do decide to change this, we should be sure to update this consistently for all .deb based distros (so also the Debian installation instructions, as well as the Docker EE instructions).

@ijc @tianon WDYT?

docker-ce | 5:18.09.0~3-0~ubuntu-xenial | {{ download-url-base }} xenial/stable amd64 Packages
docker-ce | 18.06.1~ce~3-0~ubuntu | {{ download-url-base }} xenial/stable amd64 Packages
docker-ce | 18.06.0~ce~3-0~ubuntu | {{ download-url-base }} xenial/stable amd64 Packages
$ apt policy docker-ce
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should use apt list -a docker-ce instead;

apt list -a docker-ce
Listing... Done
docker-ce/bionic,now 5:18.09.1~3-0~ubuntu-bionic amd64 [installed]
docker-ce/bionic 5:18.09.0~3-0~ubuntu-bionic amd64
docker-ce/bionic 18.06.1~ce~3-0~ubuntu amd64
docker-ce/bionic 18.06.0~ce~3-0~ubuntu amd64
docker-ce/bionic 18.05.0~ce~3-0~ubuntu amd64
docker-ce/bionic 18.03.1~ce~3-0~ubuntu amd64

@tianon
Copy link
Contributor

tianon commented Feb 7, 2019

Yeah I'm not sure on this, apt is officially discouraged for use in scripts and apt-get is likely to stay supported for a long time, so it might be worth mentioning both.

@bermudezmt
Copy link
Contributor

Hello @tianon and @thaJeztah - let me know what you decide. My gut tells me we can postpone the change, since it involves updating all Debian installation pages including EE, and making a note of the stability of apt-get. Happy to make the necessary changes though if we decide to proceed.

@thaJeztah
Copy link
Member

Yes, perhaps we should postpone this change. I think most users familiar with their Linux distro would know that apt and apt-get are interchangeable for these examples, so (if they prefer apt) would already use that.

For those that copy/paste the instructions from this page, it wouldn't make a big difference.

So, when in doubt, "no" is the safe answer ("no is temporary, yes is forever")

@bermudezmt
Copy link
Contributor

Thank you for linking that tweet @thaJeztah - such wisdom.

@RukkiesMan Thank you for your feedback! We've decided not to incorporate your suggested changes at this time, but rest assured, we will consider this change on our content refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants