Auto update failed

[jsma]

• I applied the auto-update from 4.6.1 to 4.7.0, clicked to restart.
• Docker closed and never reopened.
• I ran docker ps from the command line:

-bash: docker: command not found

• I manually navigate to Applications to launch:

Expected behavior

The update would succeed

Actual behavior

The update uninstalled the old version but encountered some sort of issue when downloading the update, resulting in a corrupted file about 50% of the size it should have been (also note the wacky "Created" date):

After manually downloading the update, the correct file size is shown:

There were no obvious network disruptions during the update. But even if there were, Docker Desktop should be smart enough to detect these conditions before uninstalling the old version so the user at least has a working previous version on their system and can retry the download/update process.

Does this mean that Docker doesn't even validate the integrity of the downloaded update before installing software that requires a admin password to install?

[mat007]

Hi, thanks for reporting and sorry about the issue.

Does this mean that Docker doesn't even validate the integrity of the downloaded update before installing software that requires a admin password to install?

We’re actually using a tool/library called Sparkle which is well known and used on macOS to handle updates.
It’s a bit of a black box though, and we’re considering rewriting the code so that we get more control…

Can you upload some diagnostics following https://docs.docker.com/desktop/mac/troubleshoot/#diagnose-and-feedback so that we can have a look at the logs?

Thanks!

[aexvir]

same here... that MacOS folder doesn't exist after the faulty update on my machine, so it's not possible to run any diagnostic; the only solution I found has been to reinstall it
this is not the first time docker for mac ends up in this state after an upgrade... it's quite frustrating

[jsma]

@mat007

it's not possible to run any diagnostic; the only solution I found has been to reinstall it

This is my situation as well, unless a clean install of v4.7.0 can somehow reach back in time to diagnose what happened before it was installed by the previous version. If so, let me know and I'll try.

On a side note, according to the Diagnose and feedback guide, we're supposed to log into our account first. I can't log into Docker Deskop because it opens my default browser (Firefox) to a login page, I log in, and then I am redirected to a blank page because Firefox is blocking a ton of tracking scripts on an auth redirect page (since I can't see the page, I think all this page does is open the pop up so I can have it open a "link" in the Desktop app to complete the process):

Is any of that tracking necessary for getting authenticated in the app?

[mat007]

This is my situation as well, unless a clean install of v4.7.0 can somehow reach back in time to diagnose what happened before it was installed by the previous version. If so, let me know and I'll try.

Yes, that’s what I meant, sorry I should have said that explicitly.
So, after installing another version (either a fresh 4.7.0 or even a 4.6.x), just run the diagnosing tool either from the UI (open the Troubleshoot and wait a bit) or from the command line (see instructions in the docs). You don’t need to be logged in, it’s only to open a support ticket if you have a paid subscription.
This will collect logs and such, make a zip, and upload it. Then it gives you an ID (a long hash with dashes) which will then allow us to retrieve the zip and look at the logs.

Is any of that tracking necessary for getting authenticated in the app?

No, but your browser needs to open that page to redirect to a URL with a custom protocol, which will reach the Docker Desktop application.

[Brodan]

This just happened to me as well. Docker told me there was an update so I downloaded it. I clicked 'Update and Reinstall' and then it corrupted my install. Now I can't start Docker. I tried to download a fresh DMG from the website for M1 Mac and it keeps crashing on install and saying it's corrupted. Great update thanks.

[mat007]

Hi @Brodan, sorry to hear that.

It’s just a file copy (well a folder copy really as a .app is a folder), so what do you mean by «crashing on install»? The file copy fails somehow?

We’ve had a few reports of people having to copy several times out of the DMG until macOS agreed to launch the app. We’re really scratching our heads on that one, given it should really not happen (unless disk corruption or whatever…).

edit: do you remember which version you updated from initially?

[flowl]

The reply to the privacy concerns is not satisfying.
Even mouse cursor tracking is enabled.
Poor privacy, big dislike.

[mat007]

I have forwarded the tracking concerns to the proper team, and I am waiting for their response. Thanks for raising that!

[mat007]

Back to original issue, to sum things up:

• The only way to fix this when it happens is to download a fresh Docker Desktop, and copy it over the broken one. This should just work, keeping all existing data (images, containers, volumes, …)
• We have managed to reproduce the issue exactly two times internally (and we have dozens of engineers updating Docker Desktop every few days, plus a lot of CI as well). The logs were very… empty. It looks like the update tool we use (Sparkle, very common, used in many macOS apps) just bails when trying to copy a file, for a reason we haven’t yet totally understood.
• We are still trying to figure out the best course of action here, we have plans to rewrite the whole in-app update code (mainly because we want to same behaviour in the new Docker Desktop for Linux, and consolidating the code at the same time would be great), so that would give us a lot more control and probably fix that issue at the same time.
• As a side note, a super frustrating trait of update code is that it needs two releases to actually fix a bug: users need to update to fix the update bug, which prevents them to update in the first place… We’re also starting to think about ways to re-architecture the code to work around that.

If you’re experiencing this issue, no need to add a new comment unless you have more information/data to provide.
But by all means, do add a 👍 to the issue description at the top!
It’s the best way for us to prioritize and balance fixes against new features, etc…

[ncouse]

This happened to me on several upgrades, and just now on 4.7.0->4.7.1

What I did notice is that the Contents/MacOS directory was completely missing after upgrade.
I had to reinstall to solve it.

What I did notice was that on the Upgrade screen, I click the "Install and Upgrade" (I can remember exactly what the button text was), and there was no feedback. I may have tried several times. Eventually I click Cancel at the bottom of the screen and realised it was actually updating anyway. Just a guess, but perhaps me be able to click the button multiple times causes issues.

[mat007]

Just a guess, but perhaps me be able to click the button multiple times causes issues.

I believe this was discussed at one of our standups last week, and the general consensus was that this should not trigger any sort of race all the way down. But I think I’ll create a ticket to double-check nonetheless…
We need another ticket to fix the UI though, as this is really poor UX indeed.

Thanks!

[rmsy]

This just happened to me as well (going from 4.6.? to 4.7.1). Like the last commenter, I too did click "Update and Restart" multiple times, because I didn't get any immediate visual feedback.