build/bake: inline GitHub runtime handling in workflows#216
Conversation
1f2cf5e to
58cf3dd
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
58cf3dd to
4b67ea8
Compare
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @crazy-max 🏅
PS. Unrelated to this change, I noticed that the container images pulled from DockerHub are not pinned by digest. Which can be deceiving as pinning the workflow does not actually propagate to the underlying tools like buildkit, binfmt, etc. Also actions-toolkit, unlike all others actions, this one is not pinned by hash.
Thanks for calling this out. For the The change generates the shrinkwrap during the publish workflow after This doesn't change the image digest point; those are separate follow-up hardening items for the workflow that we should take care of. |
fixes #210
This removes
crazy-max/ghaction-github-runtimefrom the reusable build and bake workflows while preserving GitHub Actions cache signing behavior.The prepare jobs now detect OIDC availability directly from
process.envinside their existingactions/github-scriptsetup logic. The build jobs expose only the OIDC request token and URL as masked step outputs forsetup-buildx-actiondriver options.This keeps the trusted workflow path inside Docker-owned workflow code and avoids depending on a third-party action just to surface runner-provided GitHub runtime values.
cc @stefanprodan