sockets: minor cleanups #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o arg
These utilities are created for a specific proto ("unix", or "npipe"),
so the protocol should not be passed as an arguments as it cannot be
overridden.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Aug 11, 2025
| import "net/http" | ||
|
|
||
| func configureNpipeTransport(tr *http.Transport, proto, addr string) error { | ||
| func configureNpipeTransport(any, string) error { |
Member
Author
There was a problem hiding this comment.
used any here, as it's only a stub to produce an error.
Member
Author
|
Dusting-off some changes I still had stashed locally 😅 |
- Move the dummyAddr type definition and methods together. - Change the InmemSocket.address field to a dummyAddr; the field is un-exported and could only be set through the constructor, so we can convert it when doing so. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
sockets_cleanups
branch
from
db8819c to
c4439ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sockets: configureUnixTransport, configureNpipeTransport: remove proto arg
These utilities are created for a specific proto ("unix", or "npipe"),
so the protocol should not be passed as an arguments as it cannot be
overridden.
sockets: InmemSocket: use dummyAddr as field-type
un-exported and could only be set through the constructor, so we
can convert it when doing so.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)