Merged
Conversation
Member
|
Is the files list something that end users would find useful or is it something that could help associate the package with the command that added the package. And in that case we would add a reference to the command in here instead of the file list itself. |
Contributor
Author
|
I think both have valid use cases. Knowing the command that added the package is helpful for automated patching tools, etc, but the raw file list by itself is useful I think - if after build, a user discovers an issue with a file, the package file list is an audit trail for "how did this file get here". |
tonistiigi
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List package files in output.
Note: this produces strange results if duplicate files appear in
hasFiles, so we skip over them to prevent a panic (though we still produce the wrong result). For syft, this should be fixed in anchore/syft#1168.