Skip to content

Add volume List/Get calls#22

Merged
calavera merged 1 commit intodocker:masterfrom
cpuguy83:add_volume_ls_get
Feb 1, 2016
Merged

Add volume List/Get calls#22
calavera merged 1 commit intodocker:masterfrom
cpuguy83:add_volume_ls_get

Conversation

@cpuguy83
Copy link
Copy Markdown
Contributor

Also adds tests for the volume API

@cpuguy83
Copy link
Copy Markdown
Contributor Author

ping @calavera

@runcom
Copy link
Copy Markdown
Collaborator

runcom commented Jan 21, 2016

Ci is broken :(

@cpuguy83
Copy link
Copy Markdown
Contributor Author

yeah, what the heck is that.

@calavera
Copy link
Copy Markdown
Contributor

you might want to re-push to force a new shiny build.

@cpuguy83 cpuguy83 force-pushed the add_volume_ls_get branch 2 times, most recently from 7589418 to e44a558 Compare January 22, 2016 14:43
@cpuguy83
Copy link
Copy Markdown
Contributor Author

wtf is up with the ci here...

@vdemeester
Copy link
Copy Markdown
Contributor

ping @calavera @runcom @cpuguy83 how are we on that ? This would be really cool to have it merged 👼

Travis-ci is green, and circleci should be disabled I think.

Also adds tests for the volume API

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@runcom
Copy link
Copy Markdown
Collaborator

runcom commented Jan 30, 2016

This LGTM

@calavera
Copy link
Copy Markdown
Contributor

calavera commented Feb 1, 2016

I've disabled CircleCI in this repo.

Change LGTM.

calavera added a commit that referenced this pull request Feb 1, 2016
@calavera calavera merged commit 2bce64a into docker:master Feb 1, 2016
@vdemeester
Copy link
Copy Markdown
Contributor

@calavera 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants