Adds shim layer for writing volume drivers#34
Merged
runcom merged 1 commit intodocker:masterfrom Feb 17, 2016
Merged
Conversation
Contributor
Author
|
Just throwing this out there. Had the idea while reviewing the graphdriver PR... which itself has simpler types. |
This allows a plugin writer to not care about the plugin API and rather focus on the volume driver API from engine. As ane example, engine's built-in `local` driver can operate as a plugin with no extra effort with this shim layer. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
c02def9 to
61113e3
Compare
Contributor
Author
|
ping @calavera |
Contributor
|
LGTM |
1 similar comment
Collaborator
|
LGTM |
runcom
added a commit
that referenced
this pull request
Feb 17, 2016
Adds shim layer for writing volume drivers
|
Be aware of that: |
Contributor
Author
|
@h0tbird Do you have your vendor of Docker up to date? |
|
I am running on an updated Arch Linux with Docker: |
Contributor
Author
|
@h0tbird The docker source code needs to be using the 1.10.1 tag. It seems you've got a different versin checked out. |
|
@cpuguy83 Thank you. I see my error, it works now. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a plugin writer to not care about the plugin API and rather
focus on the volume driver API from engine.
As an example, engine's built-in
localdriver can operate as a pluginwith no extra effort with this shim layer.