sdk: check systemd running for socket activation#37
Merged
calavera merged 1 commit intodocker:masterfrom Mar 14, 2016
Merged
Conversation
Collaborator
Author
|
ping @calavera @dave-tucker |
runcom
force-pushed
the
socket-activate-tcp
branch
from
74a801b to
035f61c
Compare
Contributor
|
As mentioned in #29 (comment), socket activation should NOT be enabled without checking if the host is using systemd. |
| } | ||
|
|
||
| func setupSocketActivation() (net.Listener, error) { | ||
| if !util.IsRunningSystemd() { |
runcom
force-pushed
the
socket-activate-tcp
branch
from
035f61c to
3599461
Compare
runcom
changed the title
runcom
force-pushed
the
socket-activate-tcp
branch
from
3599461 to
9fc3bf8
Compare
Collaborator
Author
|
my tests work well, I'm gonna research more about tcp - I've edited the PR to just add the check for systemd, @calavera PTAL |
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
socket-activate-tcp
branch
from
9fc3bf8 to
f0fe1a9
Compare
Contributor
|
LGTM |
Collaborator
Author
|
ping @dave-tucker (who else? :)) |
calavera
added a commit
that referenced
this pull request
Mar 14, 2016
sdk: check systemd running for socket activation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca runcom@redhat.com