Skip to content

chore(config): use registry.AuthConfig everywhere possible and deprecated config.AuthConfig#107

Merged
mdelapenya merged 1 commit into
docker:mainfrom
ndeloof:registry.AuthConfig
Oct 20, 2025
Merged

chore(config): use registry.AuthConfig everywhere possible and deprecated config.AuthConfig#107
mdelapenya merged 1 commit into
docker:mainfrom
ndeloof:registry.AuthConfig

Conversation

@ndeloof
Copy link
Copy Markdown
Contributor

@ndeloof ndeloof commented Oct 16, 2025

What does this PR do?

use registry.AuthConfig everywhere possible and deprecated config.AuthConfig

Why is it important?

this reduce coupling with config module, relying on existing docker API types (strictly equivalent)

Copilot AI review requested due to automatic review settings October 16, 2025 16:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase to use registry.AuthConfig from the Docker API instead of the local config.AuthConfig type, reducing coupling with the config module and leveraging existing Docker API types.

  • Replaces config.AuthConfig with registry.AuthConfig throughout the codebase
  • Updates the config.AuthConfig type to be an alias to registry.AuthConfig and marks it as deprecated
  • Simplifies adapter functions since the types are now equivalent

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
config/types.go Converts AuthConfig to an alias of registry.AuthConfig and marks it deprecated
config/auth.go Updates function signatures and removes redundant conversion methods
config/config.go Updates all internal usage to registry.AuthConfig type
config/auth_test.go Updates test cases to use registry.AuthConfig
config/config_test.go Updates test configurations to use registry.AuthConfig
config/config_benchmarks_test.go Updates benchmark configurations to use registry.AuthConfig
config/credentials_helpers.go Updates credential helper function to return registry.AuthConfig
legacyadapters/config/auth.go Simplifies adapter functions since types are now equivalent
legacyadapters/config/auth_test.go Updates test cases to use registry.AuthConfig
legacyadapters/README.md Updates documentation examples to use registry.AuthConfig

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread legacyadapters/config/auth.go
Comment thread config/auth.go
@ndeloof ndeloof changed the title use registry.AuthConfig everywhere possible and deprecated config.AuthConfig chore(config): use registry.AuthConfig everywhere possible and deprecated config.AuthConfig Oct 16, 2025
…hConfig

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof force-pushed the registry.AuthConfig branch from 7ccb7ce to 72492d3 Compare October 16, 2025 16:12
@ndeloof ndeloof requested review from glours and mdelapenya October 16, 2025 16:55
Copy link
Copy Markdown
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Oct 20, 2025
@mdelapenya mdelapenya merged commit df1d8fe into docker:main Oct 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants