chore(config): use registry.AuthConfig everywhere possible and deprecated config.AuthConfig#107
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to use registry.AuthConfig from the Docker API instead of the local config.AuthConfig type, reducing coupling with the config module and leveraging existing Docker API types.
- Replaces
config.AuthConfigwithregistry.AuthConfigthroughout the codebase - Updates the
config.AuthConfigtype to be an alias toregistry.AuthConfigand marks it as deprecated - Simplifies adapter functions since the types are now equivalent
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| config/types.go | Converts AuthConfig to an alias of registry.AuthConfig and marks it deprecated |
| config/auth.go | Updates function signatures and removes redundant conversion methods |
| config/config.go | Updates all internal usage to registry.AuthConfig type |
| config/auth_test.go | Updates test cases to use registry.AuthConfig |
| config/config_test.go | Updates test configurations to use registry.AuthConfig |
| config/config_benchmarks_test.go | Updates benchmark configurations to use registry.AuthConfig |
| config/credentials_helpers.go | Updates credential helper function to return registry.AuthConfig |
| legacyadapters/config/auth.go | Simplifies adapter functions since types are now equivalent |
| legacyadapters/config/auth_test.go | Updates test cases to use registry.AuthConfig |
| legacyadapters/README.md | Updates documentation examples to use registry.AuthConfig |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…hConfig Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
7ccb7ce to
72492d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
use registry.AuthConfig everywhere possible and deprecated config.AuthConfig
Why is it important?
this reduce coupling with
configmodule, relying on existing docker API types (strictly equivalent)