Remote Clients should be long-lived#324
Merged
slimslenderslacks merged 1 commit intomainfrom Jan 7, 2026
Merged
Conversation
The remote clients should be cached by ServerSession
xenoscopic
approved these changes
Jan 6, 2026
cmrigney
reviewed
Jan 6, 2026
|
|
||
| // IsRemote returns true if this server is a remote MCP server (not a Docker container) | ||
| func (sc *ServerConfig) IsRemote() bool { | ||
| return sc.Spec.SSEEndpoint != "" || sc.Spec.Remote.URL != "" |
Contributor
There was a problem hiding this comment.
fwiw, you should also be able to check the Type is remote.
cmrigney
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote clients should be cached by ServerSession
What I did
This is an optimization. It's a long-standing issue that the http transport clients can be cached by ServerSession (equivalent to one unique client connection to the gateway).