Skip to content
This repository was archived by the owner on Oct 6, 2025. It is now read-only.

Conversation

@ekcasey
Copy link
Contributor

@ekcasey ekcasey commented Jul 9, 2025

Description:

  • When the <target> in docker model tag <source> <target> does not explicitly specify the registry, do not add the implicit index.docker.io to the repo name sent to the registry. Instead, allow the registry to remain implicit.
  • Allows the CLI to decide what message is printed on success instead of printing whatever is sent from the backend.

Example:

> docker model tag ai/smollm2 emilycasey003/smollm2
Model "ai/smollm2" tagged successfully with "emilycasey003/smollm2"

> docker model ls
MODEL NAME                         PARAMETERS  QUANTIZATION    ARCHITECTURE  MODEL ID      CREATED       SIZE
ai/smollm2                         361.82 M    IQ2_XXS/Q4_K_M  llama         354bf30d0aa3  3 months ago  256.35 MiB
emilycasey003/smollm2:latest       361.82 M    IQ2_XXS/Q4_K_M  llama         354bf30d0aa3  3 months ago  256.35 MiB

Note: while we likely also want to do this with the implicit :latest tag so it doesn't show up explicitly in the model list when it wasn't specified, this would require the model-runner API to accept a missing tag query param and any version of the CLI that depended on this change would be incompatible with older version of model runner.

Signed-off-by: Emily Casey <emily.casey@docker.com>
@ekcasey ekcasey requested a review from doringeman July 9, 2025 04:37
Copy link
Collaborator

@doringeman doringeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@ekcasey ekcasey merged commit 72d2dd1 into main Jul 11, 2025
6 checks passed
@ekcasey ekcasey deleted the tag-with-implicit-registry branch July 11, 2025 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants