build: fix libvulkan1 installation

[doringeman]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build-time issue in the Dockerfile related to package installation. It introduces a new build argument, LLAMA_SERVER_VARIANT, to enable more flexible build configurations. The primary change involves refining the apt-get install command to correctly parse package names, specifically ensuring the proper installation of libvulkan1 for certain server variants, thereby enhancing the robustness of the Docker image build process.

Highlights

• Docker Build Argument: Introduced LLAMA_SERVER_VARIANT as a build argument in the Dockerfile, allowing for dynamic configuration during the image build process.
• Package Installation Fix: Corrected the apt-get install command within the Dockerfile by removing double quotes around the $packages variable, which resolves an issue with libvulkan1 installation for 'generic' or 'cpu' server variants.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR fixes the libvulkan1 installation in the Dockerfile by addressing issues with variable scoping and string interpolation in the package installation command.

• Adds the LLAMA_SERVER_VARIANT ARG declaration to make it available in the final stage
• Removes quotes around the $packages variable to ensure proper expansion during apt-get install

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gemini-code-assist]

Code Review

This pull request introduces two fixes to the Dockerfile to ensure libvulkan1 is installed correctly. First, it properly passes the LLAMA_SERVER_VARIANT build argument to the final image stage, making it available for conditional logic. Second, it corrects the apt-get install command by removing quotes around the $packages variable. This allows the shell to correctly split the package names into separate arguments. Both changes are correct and necessary, and I have no further recommendations.