README.md updates for monorepo#203
Conversation
Now that we have consolidated into one repo, we can reword some details to reflect that. Also trying to trim so fat. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR streamlines the README by consolidating content for a monorepo setup, removing outdated sections, and rephrasing the project description to reflect Docker Model Runner’s unified experience. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README.md to reflect the consolidation into a monorepo structure and streamlines the documentation by removing redundant information. The changes align the documentation with the new unified repository approach while making it more concise.
Key changes:
- Updated project description to be more comprehensive and user-focused
- Removed references to separate repositories now that components are consolidated
- Eliminated redundant sections and development warnings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary of ChangesHello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| @@ -1,31 +1,10 @@ | |||
| # Model Runner | |||
|
|
|||
| The backend library for the | |||
There was a problem hiding this comment.
Stating this repo specifically as a backend, doesn't make sense anymore as this is a complete repo for all of DMR.
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to reflect the project's new monorepo structure. The changes simplify the introduction and remove outdated information about separate repositories. My review focuses on ensuring that important context for contributors and users is not lost in the process of trimming the content. I've suggested re-adding a stability warning if the API is still unstable, and restoring a concise architecture overview to help orient new contributors to the project's components.
| - **[model-runner](https://github.com/docker/model-runner)** (this repository) - The backend daemon/server that manages and runs AI models | ||
| - **[model-cli](https://github.com/docker/model-cli)** - The CLI client that communicates with model-runner | ||
| - **[model-spec](https://github.com/docker/model-spec)** - The specification for packaging models as OCI artifacts | ||
| This package supports the Docker Model Runner in Docker Desktop and Docker Engine. |
There was a problem hiding this comment.
We went GA so some of these things are not necessary.
We only mentioned support for Docker Desktop in the past on this README.md, which is misleading.
"This guide is for external contributors". All contributors should be treated the same.
Now that we have consolidated into one repo, we can reword some details to reflect that.
Also trying to trim so fat.
Summary by Sourcery
Update README.md to reflect the consolidated monorepo structure and streamline project documentation
Documentation: