Use 25.10 vulkan

[ericcurtin]

It should have half decent hardware support and supports ARM.

Summary by Sourcery

Simplify Vulkan support by installing the libvulkan1 package and removing manual SDK download, build logic, and related Dockerfile environment variables

Enhancements:

• Replace manual Vulkan SDK download and build with installation of the libvulkan1 apt package

Build:

• Remove VULKAN_SDK environment variable settings from the Dockerfile

Chores:

• Delete custom Vulkan SDK installation and associated build dependencies from the installation script

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Simplify Vulkan support by replacing the manual SDK download and build process with the libvulkan1 package and removing SDK environment variable setup in the Dockerfile.

Class diagram for updated apt-install.sh script logic

classDiagram
    class AptInstall {
        +main()
        -vulkan_version
        -arch
        -Manual Vulkan SDK install (removed)
        +libvulkan1 install
    }
    AptInstall : +packages[]
    AptInstall : +apt-get update
    AptInstall : +apt-get install -y
    AptInstall : -wget, tar, build deps (removed)
    AptInstall : +libvulkan1

Loading

File-Level Changes

Change	Details	Files
Use libvulkan1 instead of manual Vulkan SDK installation	Remove download, extraction, build, and install steps for Vulkan SDK Add libvulkan1 to the apt install packages list	scripts/apt-install.sh
Remove Vulkan SDK environment variables from Docker configuration	Delete VULKAN_SDK, PATH, LD_LIBRARY_PATH, CMAKE_PREFIX_PATH, and PKG_CONFIG_PATH environment settings	Dockerfile

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[Copilot]

Pull Request Overview

This PR simplifies Vulkan installation by replacing custom SDK installation with system package management. It removes the complex custom Vulkan SDK installation process and switches to using the standard libvulkan1 package from the distribution's package manager, which should provide better hardware support and ARM compatibility.

• Simplified Vulkan installation using system packages instead of custom SDK
• Removed custom build process for non-x86_64 architectures
• Cleaned up Docker environment variables related to custom Vulkan SDK

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
scripts/apt-install.sh	Replaced complex custom Vulkan SDK installation with simple libvulkan1 package
Dockerfile	Removed environment variables specific to custom Vulkan SDK installation

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gemini-code-assist]

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Vulkan integration process by moving away from a custom Vulkan SDK download and build approach. Instead, it now relies on the system's package manager to install the libvulkan1 runtime library. This change aims to streamline the build process, reduce image complexity, and enhance compatibility across various hardware platforms, including ARM, as indicated by the PR description.

Highlights

• Vulkan Installation Simplification: The method for installing Vulkan has been simplified by switching from manually downloading and building the Vulkan SDK to directly installing the libvulkan1 package via apt-get.
• Dockerfile Cleanup: Explicit environment variable configurations related to the Vulkan SDK, such as VULKAN_SDK, PATH, LD_LIBRARY_PATH, CMAKE_PREFIX_PATH, and PKG_CONFIG_PATH, have been removed from the Dockerfile.
• Enhanced Hardware Support: This change is intended to improve hardware support, particularly for ARM architectures, by leveraging system-provided Vulkan runtime libraries.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request simplifies the Vulkan setup by switching from a manual SDK installation to using Ubuntu's libvulkan1 package. This is a great improvement that makes the Docker image build process cleaner and more reliable, especially for ARM architectures. My main feedback is to also include the mesa-vulkan-drivers package. This will provide a software-based Vulkan implementation (lavapipe), ensuring that Vulkan can be utilized even without a dedicated GPU, which is important for the 'cpu' and 'generic' variants. Without this, the Vulkan loader won't find any devices to use.

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}