fix(scheduler): handle GPUMemoryUtilization

[doringeman]

Fix handling GPUMemoryUtilization. Without this patch, it's not taken into account.

[gemini-code-assist]

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical oversight in the scheduler's VLLM configuration by ensuring that the GPUMemoryUtilization parameter is correctly propagated. Previously, this value was not being considered, potentially leading to suboptimal resource allocation. With this fix, the scheduler will now properly utilize the provided GPU memory utilization settings, improving the accuracy and efficiency of resource management.

Highlights

• VLLM Configuration: The GPUMemoryUtilization field from the request is now correctly passed to the VLLMConfig when configuring a runner. This ensures that GPU memory utilization is properly taken into account by the scheduler.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request correctly adds handling for GPUMemoryUtilization in the scheduler's ConfigureRunner function, ensuring the setting is passed to the vLLM backend configuration. The change is correct and addresses the described issue. I've added a couple of suggestions to improve code consistency and robustness around the changed lines.

[gemini-code-assist]

The vertical alignment of field values in this struct literal is inconsistent with other struct initializations in this file (e.g., LlamaCppConfig on line 251). Standard Go formatting, as applied by gofmt, does not use this style of alignment. For consistency, it's better to remove the extra spacing.

Suggested change

	HFOverrides: req.VLLM.HFOverrides,
	GPUMemoryUtilization: req.VLLM.GPUMemoryUtilization,
	HFOverrides: req.VLLM.HFOverrides,
	GPUMemoryUtilization: req.VLLM.GPUMemoryUtilization,

[gemini-code-assist]

While this correctly passes the GPUMemoryUtilization, for consistency and to adhere to the fail-fast principle, it's best to validate this value here, similar to how HFOverrides is validated on lines 238-241. This would involve checking if GPUMemoryUtilization is within its valid range (0.0 to 1.0) before it's assigned to runnerConfig. This provides earlier feedback for invalid configurations.