-
Notifications
You must be signed in to change notification settings - Fork 82
chore: remove mdltool #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly streamlines the project by eliminating the standalone Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `pkg/distribution/README.md:7` </location>
<code_context>
## Overview
-Model Distribution is a Go library and CLI tool that allows you to package, push, pull, and manage models using container registries. It provides a simple API and command-line interface for working with models in GGUF and Safetensors format.
+Model Distribution is a Go library that allows you to package, push, pull, and manage models using container registries. It provides a simple API for working with models in GGUF and Safetensors format.
## Features
</code_context>
<issue_to_address>
**nitpick (typo):** Consider using plural "formats" when referring to GGUF and Safetensors.
Because you reference both GGUF and Safetensors, using the plural "formats" instead of "format" reads more naturally.
```suggestion
Model Distribution is a Go library that allows you to package, push, pull, and manage models using container registries. It provides a simple API for working with models in GGUF and Safetensors formats.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes the mdltool and all its associated files, including the Go source code, test files, and Makefile entries. The .gitignore and pkg/distribution/README.md files have been updated to reflect the removal of the CLI tool and to correctly reference the library's API changes. The changes are clean and consistent with the stated objective of removing the tool.
Thanks to docker#567 and docker#568. Tested in docker/model-publisher#77. Signed-off-by: Dorin Geman <dorin.geman@docker.com>
7f68bc5 to
5bb4243
Compare
ilopezluna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @doringeman!! 👏 👏
Thanks to #567 and #568. Tested in https://github.com/docker/model-publisher/pull/77.