Skip to content

Conversation

@doringeman
Copy link
Contributor

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly streamlines the project by eliminating the standalone model-distribution-tool CLI. This change consolidates the pkg/distribution module's purpose to strictly serve as a Go library for model distribution, simplifying the codebase, reducing maintenance burden, and clarifying its intended use. The removal encompasses all associated build configurations, source files, tests, and documentation.

Highlights

  • Removal of mdltool CLI: The model-distribution-tool command-line interface, along with its entire source code (cmd/mdltool/main.go), tests (cmd/mdltool/main_test.go), and dedicated Makefile (pkg/distribution/Makefile), has been completely removed from the project.
  • Makefile Cleanup: All references, build targets, variables, and help messages related to the model-distribution-tool (e.g., mdl-pull, mdl-package) have been purged from the main Makefile.
  • Documentation Update: The pkg/distribution/README.md has been updated to reflect that model-distribution is now solely a Go library, removing all mentions and examples of the mdltool CLI and adjusting library usage examples.
  • Git Ignore Update: The .gitignore file has been cleaned up to remove entries for model-distribution-tool and model-store/, which were associated with the removed CLI.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `pkg/distribution/README.md:7` </location>
<code_context>
 ## Overview

-Model Distribution is a Go library and CLI tool that allows you to package, push, pull, and manage models using container registries. It provides a simple API and command-line interface for working with models in GGUF and Safetensors format.
+Model Distribution is a Go library that allows you to package, push, pull, and manage models using container registries. It provides a simple API for working with models in GGUF and Safetensors format.

 ## Features
</code_context>

<issue_to_address>
**nitpick (typo):** Consider using plural "formats" when referring to GGUF and Safetensors.

Because you reference both GGUF and Safetensors, using the plural "formats" instead of "format" reads more naturally.

```suggestion
Model Distribution is a Go library that allows you to package, push, pull, and manage models using container registries. It provides a simple API for working with models in GGUF and Safetensors formats.
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the mdltool and all its associated files, including the Go source code, test files, and Makefile entries. The .gitignore and pkg/distribution/README.md files have been updated to reflect the removal of the CLI tool and to correctly reference the library's API changes. The changes are clean and consistent with the stated objective of removing the tool.

Thanks to docker#567 and docker#568. Tested in docker/model-publisher#77.

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Copy link
Contributor

@ilopezluna ilopezluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @doringeman!! 👏 👏

@doringeman doringeman merged commit 7804e42 into docker:main Jan 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants