Bump llama.cpp to b7815

[krissetto]

No description provided.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Summary of Changes

Hello @krissetto, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the llama.cpp submodule to the latest commit, bringing in the newest changes and improvements from the upstream llama.cpp project.

Highlights

• llama.cpp update: This PR bumps the llama.cpp submodule to commit 091a46cb8d43c0e662d04b80a3d11320d25b7d49.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the llama.cpp submodule from commit 34ce48d97a8cd5497ee418224da5bf422ed96673 to 091a46cb8d43c0e662d04b80a3d11320d25b7d49. There are no review comments provided for this change.

[doringeman]

FWIW The lint failure if now fixed on main.

It doesn't work for me ⬇️ .

make -C llamacpp clean
make -C llamacpp build
MODEL_RUNNER_PORT=8080 make run LOCAL_LLAMA=1

I see:

Initialization for llama.cpp backend runner with model sha256:9398339cb0d3b150931212377c16d2a105ddce053ec187e4397ba6e10f3ea112 in completion mode failed: llama.cpp terminated unexpectedly: llama.cpp failed: opt/homebrew/opt/openssl@3/lib/libssl.3.dylib
  Referenced from: <D357292E-FE55-331D-8B5D-D9BBBF5A6800> /Users/dorin/workspace/model-runner-3/llamacpp/install/bin/com.docker.llama-server
  Reason: tried: '/opt/homebrew/opt/openssl@3/lib/libssl.3.dylib' (file system sandbox blocked mmap() of '/opt/homebrew/Cellar/openssl@3/3.6.0/lib/libssl.3.dylib'), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/openssl@3/lib/libssl.3.dylib' (no such file), '/opt/homebrew/opt/openssl@3/lib/libssl.3.dylib' (file system sandbox blocked mmap() of '/opt/homebrew/Cellar/openssl@3/3.6.0/lib/libssl.3.dylib'), '/opt/homebrew/Cellar/openssl@3/3.6.0/lib/libssl.3.dylib' (file system sandbox blocked mmap() of '/opt/homebrew/Cellar/openssl@3/3.6.0/lib/libssl.3.dylib'), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/Cellar/openssl@3/3.6.0/lib/libssl.3.dylib' (no such file), '/opt/homebrew/Cellar/openssl@3/3.6.0/lib/libssl.3.dylib' (file system sandbox blocked mmap() of '/opt/homebrew/Cellar/openssl@3/3.6.0/lib/libssl.3.dylib')

It seems to be due to ggml-org/llama.cpp@516a4ca. I think changing every DLLAMA_CURL=OFF to DLLAMA_OPENSSL=OFF.

[krissetto]

I'll rebase on main for the linter issue.

Huh i didn't notice the error because i used docker to build (and on linux). Will TAL

[doringeman]

Thanks!

LMK if you want to change these as well, otherwise I can do it:

$ grep -rn "DLLAMA_CURL" --exclude-dir=./llamacpp/native/vendor
./llamacpp/native/rocm.Dockerfile:35:    -DLLAMA_CURL=OFF \
./llamacpp/native/musa.Dockerfile:32:    -DLLAMA_CURL=OFF \
./llamacpp/native/generic.Dockerfile:35:          -DLLAMA_CURL=OFF \
./llamacpp/native/cuda.Dockerfile:36:    -DLLAMA_CURL=OFF \
./llamacpp/native/cann.Dockerfile:33:    -DLLAMA_CURL=OFF \

[krissetto]

If i understood correctly, I think we could just remove DLLAMA_CURL since only macOS local builds are sandboxed, but i changed them all to DLLAMA_OPENSSL for sake of consistency.

Let me know if we prefer to do otherwise and I'll change it

[doringeman]

They also removed LLAMA_CURL: ggml-org/llama.cpp@516a4ca#diff-ed99c076a4accf9ff1d7ad65a79dc3802df6bc8c91c9879e12c766a1b414272bL171.