fix(launch): improve error message for missing arguments

[doringeman]

Now:

$ docker model launch
'docker model launch' requires at least 1 argument(s).

Usage:  docker model launch APP [-- APP_ARGS...]

See 'docker model launch --help' for more information

Before:

$ docker model launch
requires at least 1 arg(s), only received 0

CC @denyszhak

[gemini-code-assist]

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the user experience for the docker model launch command. It introduces a more informative error message when the command is executed without the necessary arguments, guiding users on correct usage and available options.

Highlights

• Improved Error Messaging: The error message for the docker model launch command when required arguments are missing has been significantly improved. Instead of a generic message, users will now receive a detailed message including usage instructions.
• Custom Argument Validation: The standard cobra.MinimumNArgs validation has been replaced with a custom requireMinArgs function. This new function allows for more descriptive and user-friendly error output, enhancing the command-line experience.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• cmd/cli/commands/launch.go
  • Replaced cobra.MinimumNArgs(1) with requireMinArgs(1, "launch", "APP [-- APP_ARGS...]") to provide a custom, more detailed error message when the docker model launch command is invoked without the required application argument.

Activity

• The author, doringeman, created this pull request to address an improvement in error messaging.
• The pull request description includes a 'CC @denyszhak' indicating a request for review or attention from denyszhak.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey - I've left some high level feedback:

• Instead of hardcoding "launch" and the usage string in the requireMinArgs call, consider deriving these from the command (e.g., cmd.Use or a shared constant) to avoid duplication and keep the error message in sync if the command usage changes.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Instead of hardcoding "launch" and the usage string in the `requireMinArgs` call, consider deriving these from the command (e.g., `cmd.Use` or a shared constant) to avoid duplication and keep the error message in sync if the command usage changes.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request significantly improves the user experience by providing a more informative error message when the docker model launch command is invoked without the required arguments. Replacing cobra.MinimumNArgs with the custom requireMinArgs function allows for a detailed usage message, including the command's syntax and a reference to the help documentation. This is a great enhancement for usability.

[ericcurtin]

You should blog about this by the way @denyszhak it's a cool new feature

[denyszhak]

You should blog about this by the way @denyszhak it's a cool new feature

@ericcurtin that's an interesting idea:) I might exercise that option!