Skip to content

fix: prevent shell injection in workflow inputs (CWE-78) #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doringeman merged 1 commit into from
Feb 11, 2026
Merged

fix: prevent shell injection in workflow inputs (CWE-78) #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/dmr-daily-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ jobs:
fi

- name: Test model pull and run
env:
MODEL: ${{ github.event.inputs.test_model || 'ai/smollm2:360M-Q4_K_M' }}
run: |
MODEL="${{ github.event.inputs.test_model || 'ai/smollm2:360M-Q4_K_M' }}"
echo "Testing with model: $MODEL"

# Test model pull
echo "Pulling model..."
sudo docker model pull "$MODEL"
Expand All @@ -86,10 +87,11 @@ jobs:
}

- name: Test API endpoint
env:
MODEL: ${{ github.event.inputs.test_model || 'ai/smollm2:360M-Q4_K_M' }}
run: |
MODEL="${{ github.event.inputs.test_model || 'ai/smollm2:360M-Q4_K_M' }}"
echo "Testing API endpoint with model: $MODEL"

# Test API call with curl
echo "Testing API call..."
RESPONSE=$(curl -s http://localhost:12434/engines/llama.cpp/v1/chat/completions \
Expand Down Expand Up @@ -124,9 +126,9 @@ jobs:
fi

- name: Test model cleanup
env:
MODEL: ${{ github.event.inputs.test_model || 'ai/smollm2:360M-Q4_K_M' }}
run: |
MODEL="${{ github.event.inputs.test_model || 'ai/smollm2:360M-Q4_K_M' }}"

echo "Cleaning up test model..."
sudo docker model rm "$MODEL" || echo "Model removal failed or model not found"

Expand Down
32 changes: 23 additions & 9 deletions .github/workflows/promote-to-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,46 +28,60 @@ jobs:
run: crane auth login index.docker.io -u "$DOCKERHUB_USERNAME" -p "$DOCKERHUB_TOKEN"

- name: Promote CPU images
env:
VERSION: ${{ inputs.version }}
run: |
echo "Promoting CPU images"
crane tag "docker/model-runner:${{ inputs.version }}" "latest"
crane tag "docker/model-runner:$VERSION" "latest"

- name: Promote CUDA images
env:
VERSION: ${{ inputs.version }}
run: |
echo "Promoting CUDA images"
crane tag "docker/model-runner:${{ inputs.version }}-cuda" "latest-cuda"
crane tag "docker/model-runner:$VERSION-cuda" "latest-cuda"

- name: Promote vLLM CUDA images
env:
VERSION: ${{ inputs.version }}
run: |
echo "Promoting vLLM CUDA images"
crane tag "docker/model-runner:${{ inputs.version }}-vllm-cuda" "latest-vllm-cuda"
crane tag "docker/model-runner:$VERSION-vllm-cuda" "latest-vllm-cuda"

- name: Promote SGLang CUDA images
env:
VERSION: ${{ inputs.version }}
run: |
echo "Promoting SGLang CUDA images"
crane tag "docker/model-runner:${{ inputs.version }}-sglang-cuda" "latest-sglang-cuda"
crane tag "docker/model-runner:$VERSION-sglang-cuda" "latest-sglang-cuda"

- name: Promote ROCm images
env:
VERSION: ${{ inputs.version }}
run: |
echo "Promoting ROCm images"
crane tag "docker/model-runner:${{ inputs.version }}-rocm" "latest-rocm"
crane tag "docker/model-runner:$VERSION-rocm" "latest-rocm"

- name: Promote MUSA images
env:
VERSION: ${{ inputs.version }}
run: |
echo "Checking if MUSA image exists"
if crane manifest "docker/model-runner:${{ inputs.version }}-musa" > /dev/null 2>&1; then
if crane manifest "docker/model-runner:$VERSION-musa" > /dev/null 2>&1; then
echo "Promoting MUSA images"
crane tag "docker/model-runner:${{ inputs.version }}-musa" "latest-musa"
crane tag "docker/model-runner:$VERSION-musa" "latest-musa"
else
echo "MUSA image does not exist, skipping"
fi

- name: Promote CANN images
env:
VERSION: ${{ inputs.version }}
run: |
echo "Checking if CANN image exists"
if crane manifest "docker/model-runner:${{ inputs.version }}-cann" > /dev/null 2>&1; then
if crane manifest "docker/model-runner:$VERSION-cann" > /dev/null 2>&1; then
echo "Promoting CANN images"
crane tag "docker/model-runner:${{ inputs.version }}-cann" "latest-cann"
crane tag "docker/model-runner:$VERSION-cann" "latest-cann"
else
echo "CANN image does not exist, skipping"
fi
35 changes: 19 additions & 16 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,52 +62,55 @@ jobs:
- name: Format tags
id: tags
shell: bash
env:
RELEASE_TAG: ${{ inputs.releaseTag }}
PUSH_LATEST: ${{ inputs.pushLatest }}
run: |
echo "cpu<<EOF" >> "$GITHUB_OUTPUT"
echo "docker/model-runner:${{ inputs.releaseTag }}" >> "$GITHUB_OUTPUT"
if [ "${{ inputs.pushLatest }}" == "true" ]; then
echo "docker/model-runner:$RELEASE_TAG" >> "$GITHUB_OUTPUT"
if [ "$PUSH_LATEST" == "true" ]; then
echo "docker/model-runner:latest" >> "$GITHUB_OUTPUT"
fi
echo 'EOF' >> "$GITHUB_OUTPUT"
echo "cuda<<EOF" >> "$GITHUB_OUTPUT"
echo "docker/model-runner:${{ inputs.releaseTag }}-cuda" >> "$GITHUB_OUTPUT"
if [ "${{ inputs.pushLatest }}" == "true" ]; then
echo "docker/model-runner:$RELEASE_TAG-cuda" >> "$GITHUB_OUTPUT"
if [ "$PUSH_LATEST" == "true" ]; then
echo "docker/model-runner:latest-cuda" >> "$GITHUB_OUTPUT"
fi
echo 'EOF' >> "$GITHUB_OUTPUT"
echo "vllm-cuda<<EOF" >> "$GITHUB_OUTPUT"
echo "docker/model-runner:${{ inputs.releaseTag }}-vllm-cuda" >> "$GITHUB_OUTPUT"
if [ "${{ inputs.pushLatest }}" == "true" ]; then
echo "docker/model-runner:$RELEASE_TAG-vllm-cuda" >> "$GITHUB_OUTPUT"
if [ "$PUSH_LATEST" == "true" ]; then
echo "docker/model-runner:latest-vllm-cuda" >> "$GITHUB_OUTPUT"
fi
echo 'EOF' >> "$GITHUB_OUTPUT"
echo "sglang-cuda<<EOF" >> "$GITHUB_OUTPUT"
echo "docker/model-runner:${{ inputs.releaseTag }}-sglang-cuda" >> "$GITHUB_OUTPUT"
if [ "${{ inputs.pushLatest }}" == "true" ]; then
echo "docker/model-runner:$RELEASE_TAG-sglang-cuda" >> "$GITHUB_OUTPUT"
if [ "$PUSH_LATEST" == "true" ]; then
echo "docker/model-runner:latest-sglang-cuda" >> "$GITHUB_OUTPUT"
fi
echo 'EOF' >> "$GITHUB_OUTPUT"
echo "diffusers<<EOF" >> "$GITHUB_OUTPUT"
echo "docker/model-runner:${{ inputs.releaseTag }}-diffusers" >> "$GITHUB_OUTPUT"
if [ "${{ inputs.pushLatest }}" == "true" ]; then
echo "docker/model-runner:$RELEASE_TAG-diffusers" >> "$GITHUB_OUTPUT"
if [ "$PUSH_LATEST" == "true" ]; then
echo "docker/model-runner:latest-diffusers" >> "$GITHUB_OUTPUT"
fi
echo 'EOF' >> "$GITHUB_OUTPUT"
echo "rocm<<EOF" >> "$GITHUB_OUTPUT"
echo "docker/model-runner:${{ inputs.releaseTag }}-rocm" >> "$GITHUB_OUTPUT"
if [ "${{ inputs.pushLatest }}" == "true" ]; then
echo "docker/model-runner:$RELEASE_TAG-rocm" >> "$GITHUB_OUTPUT"
if [ "$PUSH_LATEST" == "true" ]; then
echo "docker/model-runner:latest-rocm" >> "$GITHUB_OUTPUT"
fi
echo 'EOF' >> "$GITHUB_OUTPUT"
echo "musa<<EOF" >> "$GITHUB_OUTPUT"
echo "docker/model-runner:${{ inputs.releaseTag }}-musa" >> "$GITHUB_OUTPUT"
if [ "${{ inputs.pushLatest }}" == "true" ]; then
echo "docker/model-runner:$RELEASE_TAG-musa" >> "$GITHUB_OUTPUT"
if [ "$PUSH_LATEST" == "true" ]; then
echo "docker/model-runner:latest-musa" >> "$GITHUB_OUTPUT"
fi
echo 'EOF' >> "$GITHUB_OUTPUT"
echo "cann<<EOF" >> "$GITHUB_OUTPUT"
echo "docker/model-runner:${{ inputs.releaseTag }}-cann" >> "$GITHUB_OUTPUT"
if [ "${{ inputs.pushLatest }}" == "true" ]; then
echo "docker/model-runner:$RELEASE_TAG-cann" >> "$GITHUB_OUTPUT"
if [ "$PUSH_LATEST" == "true" ]; then
echo "docker/model-runner:latest-cann" >> "$GITHUB_OUTPUT"
fi
echo 'EOF' >> "$GITHUB_OUTPUT"
Expand Down