Remove unused final-diffusers Docker image variant and fix duplicate backend registration#768
Merged
Conversation
…been updated to be deferred backend)
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes the unused final-diffusers Docker image variant and its associated build artifacts from the Dockerfile, Makefile, and other related files. It also fixes an issue where the diffusers backend was being registered twice in main.go. The changes are clean, consistent, and achieve the stated goals. I have no further comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diffusers backend was migrated to deferred (on-demand) installation, where it downloads a self-contained Python environment from Docker Hub at first use. However, several artifacts from the old pre-built Docker image approach were left behind, and the backend was being registered twice in
main.go.This PR fixes that