-
Notifications
You must be signed in to change notification settings - Fork 118
chore: update vllm-metal version to v0.2.0 and vllm version to 0.19.1 #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+43
−6
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
56dce2f
chore: update vllm-metal version to v0.2.0 and upstream version to 0.…
ilopezluna be57661
chore: also update VLLM_VERSION to 0.19.1 for Linux/CUDA image
ilopezluna 1e8b176
chore: update VLLM_UPSTREAM_VERSION to 0.19.0 in .versions
ilopezluna 6c5c109
fix: allow vllm-metal cache dir in macOS sandbox
ilopezluna 7e37085
fix: keep Python include headers for vllm-metal Metal kernel compilation
ilopezluna ad2faee
fix: pre-compile vllm-metal paged_ops extension in tarball build
ilopezluna 19facfd
fix: allow file-map-executable for vllm-metal cache in macOS sandbox
ilopezluna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider surfacing or aggregating non-transient errors during prebuilt cache setup instead of fully swallowing them.
This block currently ignores all errors except a WARN on failed writes. Since this cache helps avoid JIT failures in the sandbox, it’d be helpful to separate best-effort failures from configuration issues. At minimum, consider logging when
os.UserHomeDir,os.ReadDir, oros.MkdirAllfail, or logging once when prebuilt cache setup is skipped entirely, to ease debugging of misconfigured environments.