Make llama.cpp Python cleanup optional#957
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several Dockerfiles (cann, cuda, generic, musa, and rocm) to use the force flag (rm -f) when deleting Python files from the installation directory, preventing potential build failures if no such files exist. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
doringeman
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.pyfiles are installedTesting
rg -n 'RUN rm install/bin/\\*\\.py' llamacpp/native\n-rg -n 'RUN rm -f install/bin/\\*\\.py' llamacpp/native\n-git diff --check\n\n## Notes\nThis keeps existing cleanup behavior when Python helper files are present, while avoiding a Docker build failure for builds where CMake install does not produceinstall/bin/*.py.\n