Add Docker Auth Wrapper to check for auth entries for all Docker Hub domains#3
Merged
Add Docker Auth Wrapper to check for auth entries for all Docker Hub domains#3
Conversation
jcarter3
force-pushed
the
add-docker-auth-wrapper
branch
2 times, most recently
from
22ebdca to
b8a2f8c
Compare
tianon-sso
reviewed
Apr 15, 2026
jcarter3
force-pushed
the
add-docker-auth-wrapper
branch
from
722d0a9 to
3283d71
Compare
jcarter3
force-pushed
the
add-docker-auth-wrapper
branch
from
eb9f053 to
9128ac4
Compare
tianon-sso
approved these changes
Apr 15, 2026
Member
tianon-sso
left a comment
tianon-sso
left a comment
There was a problem hiding this comment.
It feels a little bit self-serving to approve when this is still so closely my own original code but there it is 😂 ❤️
(I don't own "https://github.com/self-five" for nothing, after all)
| sorted := DockerHubHostsSorted() | ||
| for i, host := range sorted { | ||
| if i != int(DockerHubHosts[host]) { | ||
| t.Errorf("host %s not sorted", host) |
Member
There was a problem hiding this comment.
nice - I was worried this might not catch certain edge cases, but it sure does: https://go.dev/play/p/VcLZWcOKSUg
the error message sucks, but makes it really obvious you need to go back and look at the list of exactly 5 items and figure out which one is screwed up 😂 ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.