[docker-buildx-plugin] Incorrect version definition in static build (`v0.0.0+unknown`)

[wojiushixiaobai]

The static binary built via docker-buildx does not carry the correct version information, resulting in github.com/docker/buildx v0.0.0+unknown. This indicates that the version metadata was not properly injected into the Go linker during the build process.

#16 [linux/amd64 verify-static 3/3] RUN --mount=from=bin,target=/build <<EOT (set -e...)
#16 0.065 + tar zxvf /build/linux_amd64/static/linux/amd64/docker-buildx-plugin_0.33.0.tgz -C /usr/bin --strip-components=1
#16 0.067 docker-buildx-plugin/README.md
#16 0.068 docker-buildx-plugin/LICENSE
#16 0.068 docker-buildx-plugin/docker-buildx
#16 0.492 + docker-buildx version
#16 0.511 github.com/docker/buildx v0.0.0+unknown 
#16 DONE 0.5s

• packaging/pkg/buildx/scripts/pkg-static-build.sh

  Line 54 in 928861f

  go build -trimpath -ldflags="-s -w -X ${PKG_NAME}/version.Version=${GENVER_VERSION} -X ${PKG_NAME}/version.Revision=${GENVER_COMMIT} -X ${PKG_NAME}/version.Package=${PKG_NAME}" -o /tmp/buildx-build/docker-buildx ./cmd/buildx

• https://github.com/docker/buildx/blob/43fe71eabaf75f7ba4eaeae288983d653380b9ab/Dockerfile#L82

diff --git a/pkg/buildx/scripts/pkg-static-build.sh b/pkg/buildx/scripts/pkg-static-build.sh
index 95a7792..49a652b 100755
--- a/pkg/buildx/scripts/pkg-static-build.sh
+++ b/pkg/buildx/scripts/pkg-static-build.sh
@@ -51,7 +51,7 @@ mkdir -p ${BUILDDIR}/${PKG_NAME}
 (
   set -x
   pushd ${SRCDIR}
-    go build -trimpath -ldflags="-s -w -X ${PKG_NAME}/version.Version=${GENVER_VERSION} -X ${PKG_NAME}/version.Revision=${GENVER_COMMIT} -X ${PKG_NAME}/version.Package=${PKG_NAME}" -o /tmp/buildx-build/docker-buildx ./cmd/buildx
+    go build -trimpath -ldflags="-s -w -X github.com/docker/buildx/version.Version=${GENVER_VERSION} -X github.com/docker/buildx/version.Revision=${GENVER_COMMIT} -X github.com/docker/buildx/version.Package=github.com/docker/buildx" -o /tmp/buildx-build/docker-buildx ./cmd/buildx
     mv "/tmp/buildx-build/docker-buildx" "${BUILDDIR}/${PKG_NAME}/docker-buildx${binext}"
   popd
   xx-verify --static "${BUILDDIR}/${PKG_NAME}/docker-buildx${binext}"

[wojiushixiaobai]

Missing TAGPREFIX definition in docker-engine.

#37 0.060 + : ''
#37 0.060 + srcdir=/usr/local/src/engine
#37 0.060 + '[' -z /usr/local/src/engine ']'
#37 0.060 + tagregex='v[0-9]*'
#37 0.060 ++ git -C /usr/local/src/engine describe --match 'v[0-9]*' --tags
#37 0.095 + version=v2.0.0-beta.9-33-g828f87ccfd

• packaging/hack/scripts/gen-ver.sh

  Lines 18 to 32 in 928861f

  	# optional tag prefix to handle versions like:
  	# cmd/cli/v0.1.44 -> v0.1.44
  	# docker-v29.0.0 -> v29.0.0
  	: "${TAGPREFIX:=}"
  	srcdir="$1"
  	if [ -z "$srcdir" ]; then
  	echo "usage: ./gen-ver <srcdir>" >&2
  	exit 1
  	fi
  	tagregex="${TAGPREFIX}v[0-9]*"
  	version=$(git -C "${srcdir}" describe --match "$tagregex" --tags)
  	commit="$(git --git-dir "${srcdir}/.git" rev-parse HEAD)"
  	commitShort=${commit:0:7}

diff --git a/pkg/docker-engine/Dockerfile b/pkg/docker-engine/Dockerfile
index f0af3de6..dbbaa571 100644
--- a/pkg/docker-engine/Dockerfile
+++ b/pkg/docker-engine/Dockerfile
@@ -34,6 +34,8 @@ ARG GO_IMAGE="golang"
 ARG GO_VERSION="1.26.1"
 ARG GO_IMAGE_VARIANT="bookworm"
 
+ARG TAGPREFIX="docker-"
+
 # stage used as named context that mounts hack/scripts
 # see pkg target in docker-bake.hcl
 FROM scratch AS scripts
@@ -65,6 +67,7 @@ FROM src-base AS metadata-builder
 ARG PKG_REPO
 ARG PKG_REF
 ARG NIGHTLY_BUILD
+ARG TAGPREFIX
 RUN --mount=type=bind,from=scripts,source=gen-ver.sh,target=/usr/local/bin/gen-ver \
     --mount=type=bind,from=src,source=/src,target=/src <<EOT
   set -e
@@ -120,6 +123,7 @@ ARG PKG_DEB_BUILDFLAGS
 ARG PKG_DEB_REVISION
 ARG PKG_DEB_EPOCH
 ARG SOURCE_DATE_EPOCH
+ARG TAGPREFIX
 ENV CMAKE_POLICY_VERSION_MINIMUM=3.5
 RUN --mount=type=bind,source=scripts/pkg-deb-build.sh,target=/usr/local/bin/pkg-deb-build \
     --mount=type=bind,source=scripts/check-gomod.sh,target=/usr/local/bin/check-gomod \
@@ -167,6 +171,7 @@ ARG PKG_PACKAGER
 ARG PKG_RPM_BUILDFLAGS
 ARG PKG_RPM_RELEASE
 ARG SOURCE_DATE_EPOCH
+ARG TAGPREFIX
 RUN --mount=type=bind,source=scripts/pkg-rpm-build.sh,target=/usr/local/bin/pkg-rpm-build \
     --mount=type=bind,source=scripts/check-gomod.sh,target=/usr/local/bin/check-gomod \
     --mount=type=bind,from=scripts,source=gen-ver.sh,target=/usr/local/bin/gen-ver \
@@ -196,6 +201,7 @@ RUN apt-get install -y --no-install-recommends clang cmake gcc libc6-dev lld llv
 ARG PKG_NAME
 ARG PKG_REF
 ARG NIGHTLY_BUILD
+ARG TAGPREFIX
 WORKDIR /build
 ARG TARGETPLATFORM
 RUN xx-apt-get install -y gcc libc6-dev libapparmor-dev libnftables-dev libsecret-1-dev libsystemd-dev libudev-dev pkg-config

[crazy-max]

Hum good catch: https://github.com/docker/packaging/actions/runs/23805799337/job/69511360320#step:7:1018

I'm going to bisect

[crazy-max]

#347 seems to be the regression