chore: align go version from upstream repositories#394
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
||
| ARG GO_IMAGE="golang" | ||
| ARG GO_VERSION="1.25.8" | ||
| ARG GO_VERSION="1.26.0" |
There was a problem hiding this comment.
Argh this is wrong; they merged with .0 as version, so now we'd be building with vulnerabilities? I left a comment, but looks like that was ignored; containerd/containerd#13090
There was a problem hiding this comment.
Opened a PR;
There was a problem hiding this comment.
We still need this to be merged though, see failures in other PRs: https://github.com/docker/packaging/actions/runs/24047483914/job/70134466123?pr=395#step:7:1741
2.510 go: downloading golang.org/x/text v0.32.0
4.713 + bin/gen-manpages
4.713 go build -gcflags=-trimpath=/go/src -buildmode=pie -o bin/gen-manpages -ldflags '-X github.com/containerd/containerd/v2/version.Version=v2.3.0-beta.0-119-ge373060a9 -X github.com/containerd/containerd/v2/version.Revision=e373060a953aeaa35554e2f667043fed73ff6248 -X github.com/containerd/containerd/v2/version.Package=github.com/containerd/containerd/v2 -s -w ' -tags "" ./cmd/gen-manpages
4.718 go: go.mod requires go >= 1.26.0 (running go 1.25.8; GOTOOLCHAIN=local)
4.718 make: *** [Makefile:268: bin/gen-manpages] Error 1
4.719 error:
4.719
4.719 RPM build errors:
4.719 Bad exit status from /var/tmp/rpm-tmp.Y1N6Q6 (%build)
4.719 Bad exit status from /var/tmp/rpm-tmp.Y1N6Q6 (%build)
------
There was a problem hiding this comment.
Ah, yes, I was hoping for my PR to be trivial and merged fast, but looks like it wasn't yet 😞
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
|
Pushed extra commit to fix https://github.com/docker/packaging/actions/runs/23843956397/job/69543962188?pr=394 |
|
Merged to unblock ci. It's fine to have it, we don't ship packages from default branch anyway but tagged releases. |
Keep Go versions in sync with upstream repositories.