store: secret.Metadata/secret.SetMetadata and store.GetAllMetadata#130
Merged
store: secret.Metadata/secret.SetMetadata and store.GetAllMetadata#130
Conversation
Benehiko
force-pushed
the
getallmetadata
branch
2 times, most recently
from
2e4901e to
8e6077f
Compare
Benehiko
changed the title
Benehiko
changed the title
…tadata This patch adds a new `secret.Metadata()` and `secret.SetMetdata()` function to the `secret` interface. This allows the underlying store from storing non-sensitive metadata and retrieving only the metadata. This patch also changes the behavior of the store.GetAll function so that it always sets metadata, but does not set the actual secret from the underlying keychain. It's very costly to read each secret from the keychain since each value needs to be decrypted. On macOS the user would be prompted for each value decrypted. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
joe0BAB
reviewed
Jul 23, 2025
joe0BAB
reviewed
Jul 23, 2025
joe0BAB
reviewed
Jul 23, 2025
joe0BAB
reviewed
Jul 23, 2025
joe0BAB
reviewed
Jul 23, 2025
joe0BAB
reviewed
Jul 23, 2025
joe0BAB
reviewed
Jul 23, 2025
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
force-pushed
the
getallmetadata
branch
3 times, most recently
from
913a4ed to
352d1b1
Compare
joe0BAB
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a new
secret.Metadata()andsecret.SetMetdata()function to the
secretinterface. This allows the underlying storefrom storing non-sensitive metadata and retrieving only the metadata.
This patch also changes the behavior of the store.GetAll function so that it
always sets metadata, but does not set the actual secret from the
underlying keychain.
It's very costly to read each secret from the keychain since each value
needs to be decrypted. On macOS the user would be prompted for each value
decrypted.