feat: new CLI to mange local secrets#190
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Hub login | ||
| uses: docker/login-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
|
|
||
| - name: Set up Docker Buildx | ||
| id: buildx | ||
| uses: docker/setup-buildx-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Hub login | ||
| uses: docker/login-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
|
|
||
| - name: Set up Docker Buildx | ||
| id: buildx | ||
| uses: docker/setup-buildx-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Hub login | ||
| uses: docker/login-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
|
|
||
| - name: Set up Docker Buildx | ||
| id: buildx | ||
| uses: docker/setup-buildx-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
joe0BAB
force-pushed
the
feat/mysecret-init
branch
from
9713cad to
bb503ad
Compare
| func newSigContext() (context.Context, func()) { | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| s := make(chan os.Signal, 1) | ||
| signal.Notify(s, syscall.SIGTERM, syscall.SIGINT) | ||
| go func() { | ||
| <-s | ||
| cancel() | ||
| }() | ||
| return ctx, cancel |
There was a problem hiding this comment.
you're missing signal.Stop on channel s.
https://github.com/docker/cli/blob/master/cmd/docker/docker.go#L52-L76
There was a problem hiding this comment.
Good call out! Let's to similar as in CLI then 😄
joe0BAB
force-pushed
the
feat/mysecret-init
branch
from
bb503ad to
fa0ffe6
Compare
3 participants
Boilerplate code to setup a new binary that also is a docker CLI plugin, can be used standalone and is build on CI.