Skip to content

Comments

chore: update readme#456

Merged
joe0BAB merged 1 commit intomainfrom
fix/readme
Feb 17, 2026
Merged

chore: update readme#456
joe0BAB merged 1 commit intomainfrom
fix/readme

Conversation

@Benehiko
Copy link
Member

No description provided.

@Benehiko Benehiko requested review from Copilot and joe0BAB and removed request for joe0BAB February 17, 2026 13:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project README to reflect current repository metadata and client usage examples.

Changes:

  • Remove outdated GitHub Actions build badge reference.
  • Update license badge to Apache 2.0.
  • Update the “query secrets” example to use GetSecrets and pattern parsing.
Comments suppressed due to low confidence (1)

README.md:45

  • The updated Quickstart snippet calls c.GetSecrets(...), which returns a slice of envelopes, but the example still treats the result as a single object (resp.Value). Also t.Context() isn’t defined in this README snippet. Update the example to use a real context.Context (e.g. context.Background() or a ctx variable) and to handle the returned slice (e.g. select the first match or iterate).
resp, err := c.GetSecrets(t.Context(), client.MustParsePattern("my-secret"))
if err != nil {
    log.Fatalf("failed fetching secret: %v", err)
}
fmt.Println(resp.Value)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

joe0BAB
joe0BAB previously approved these changes Feb 17, 2026
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
@joe0BAB joe0BAB merged commit c062c3f into main Feb 17, 2026
12 checks passed
@joe0BAB joe0BAB deleted the fix/readme branch February 17, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants