Merged
Conversation
Signed-off-by: Stanislav Hamara <stanislav.hamara@docker.com>
stanislavHamara
force-pushed
the
ADUI-1271-gha-checking-for-signatures
branch
2 times, most recently
from
0ddac30 to
4e2e94c
Compare
stanislavHamara
force-pushed
the
ADUI-1271-gha-checking-for-signatures
branch
from
4e2e94c to
041bfd2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a GitHub Actions workflow to enforce commit signature verification on pull requests according to the project's contribution guidelines.
- Added a workflow file to trigger commit signature checks for pull requests.
- Executes a shell script to verify commit signatures using either a GPG signature or a "Signed-off" message.
Files not reviewed (1)
- .github/scripts/check-commits.sh: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/verify.yml:3
- Consider adding a 'push' event trigger if commit signature verification should also be enforced on direct pushes, not only on pull requests.
pull_request:
stanislavHamara
commented
Apr 2, 2025
.github/scripts/check-commits.sh
Outdated
|
|
||
| set -e | ||
|
|
||
| signoff_regex="^Signed-off-by: [A-Za-z .'-]+ <[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,}>$" |
Contributor
Author
There was a problem hiding this comment.
@rcjsuen are we happy with just checking for "Signed-off-by:"? Using regex to check for name and email makes me feel icky :D
Collaborator
There was a problem hiding this comment.
are we happy with just checking for "Signed-off-by:"?
No worries. I am okay with this as that is what we are asking for in CONTRIBUTING.md.
rcjsuen
approved these changes
Apr 2, 2025
.github/scripts/check-commits.sh
Outdated
|
|
||
| set -e | ||
|
|
||
| signoff_regex="^Signed-off-by: [A-Za-z .'-]+ <[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,}>$" |
Collaborator
There was a problem hiding this comment.
are we happy with just checking for "Signed-off-by:"?
No worries. I am okay with this as that is what we are asking for in CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
We would like all contributors to adhere to https://github.com/docker/vscode-extension/blob/main/CONTRIBUTING.md and sign their commits
Proposed Solution
Introduce a GHA that checks that a commit has been signed by either a "Signed-off" message or with a verified GPG, SSH, or S/MIME signature.
Proof of Work
Tested: