Skip to content

Cheqd SDK upgrade, use preset gas price#572

Merged
cykoder merged 1 commit intomasterfrom
chore/upgrade-cheqd-sdk
Mar 6, 2026
Merged

Cheqd SDK upgrade, use preset gas price#572
cykoder merged 1 commit intomasterfrom
chore/upgrade-cheqd-sdk

Conversation

@cykoder
Copy link
Copy Markdown
Member

@cykoder cykoder commented Mar 5, 2026

No description provided.

@cykoder cykoder changed the title Chore/upgrade cheqd sdk @cykoder Cheqd SDK upgrade, use preset gas price Mar 5, 2026
@cykoder cykoder changed the title @cykoder Cheqd SDK upgrade, use preset gas price Cheqd SDK upgrade, use preset gas price Mar 5, 2026
@cykoder cykoder requested review from gasher and mike-parkhill March 5, 2026 22:36
@cykoder cykoder force-pushed the chore/upgrade-cheqd-sdk branch from 2bab3d5 to 3a2ca04 Compare March 5, 2026 22:47
* @returns {BigInt}
*/
async calculateFee(txOrTxs, signerAddress, estimatedGas = null, multiplier = 1.3, memo = '') {
async calculateFee(txOrTxs, signerAddress, estimatedGas = null, multiplier = 3.5, memo = '') {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From 1.3 to 3.5 seems like a big jump. Can you help me understand why such a jump is needed?

Copy link
Copy Markdown
Member Author

@cykoder cykoder Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in fee market on cheqd SDK side, this was the minimum that would still be passing/allow submission.

but dont worry, fee multiplier could even be 1000x and we dont get charged that. this is just kind of a "max fee" type thing

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks

@cykoder cykoder requested a review from gasher March 6, 2026 15:13
@cykoder cykoder merged commit 4747dd5 into master Mar 6, 2026
12 of 15 checks passed
@cykoder cykoder deleted the chore/upgrade-cheqd-sdk branch March 6, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants