Skip to content

Cloud9 IDE integration#48

Merged
lmakarov merged 7 commits into
developfrom
feature/cloud9
Jun 1, 2018
Merged

Cloud9 IDE integration#48
lmakarov merged 7 commits into
developfrom
feature/cloud9

Conversation

@lmakarov

@lmakarov lmakarov commented Jun 1, 2018

Copy link
Copy Markdown
Member

Parent issue: docksal/docksal#568

Leonid Makarov added 5 commits May 31, 2018 00:29
- Ditch nvm and install Node.js globally from NodeSource repos
- List images after build (to check image sizes)
- Starting supervisord using /etc/supervisor/supervisord.conf config, which includes /etc/supervisor/conf.d/*.conf
- Removed non-essential settings from the custom supervisor.conf - pretty much all of them are covered in /etc/supervisor/supervisord.conf (in Debian Stretch)
@lmakarov lmakarov self-assigned this Jun 1, 2018
@lmakarov

lmakarov commented Jun 1, 2018

Copy link
Copy Markdown
Member Author

Alternative way of installing node and yarn from binaries:

ENV NODE_VERSION=8.11.2
ENV YARN_VERSION 1.5.1
RUN set -xe; \
	# Nodejs
	curl -fsSLO --compressed "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz"; \
	tar -xJf "node-v$NODE_VERSION-linux-x64.tar.xz" -C /usr/local --strip-components=1; \
	rm -f "node-v$NODE_VERSION-linux-x64.tar.xz"; \
	ln -s /usr/local/bin/node /usr/local/bin/nodejs; \
	# Yarn
	curl -fsSLO --compressed "https://yarnpkg.com/downloads/$YARN_VERSION/yarn-v$YARN_VERSION.tar.gz"; \
	tar -xzf yarn-v$YARN_VERSION.tar.gz -C /opt/; \
	ln -s /opt/yarn-v$YARN_VERSION/bin/yarn /usr/local/bin/yarn; \
	ln -s /opt/yarn-v$YARN_VERSION/bin/yarnpkg /usr/local/bin/yarnpkg; \
	rm -f yarn-v$YARN_VERSION.tar.gz;

This adds 60.9MB vs 53.9MB when installing from packages.

@lmakarov lmakarov merged commit 49a0f85 into develop Jun 1, 2018
@achekulaev

Copy link
Copy Markdown
Member

@lmakarov why are we using outdated nodejs?

@lmakarov

lmakarov commented Jun 1, 2018

Copy link
Copy Markdown
Member Author

@achekulaev 8.11.2 is the current LTS release.

@achekulaev

achekulaev commented Jun 1, 2018

Copy link
Copy Markdown
Member

@lmakarov no 10.x is current LTS https://en.wikipedia.org/wiki/Node.js
8.x is previous LTS.

@lmakarov

lmakarov commented Jun 1, 2018

Copy link
Copy Markdown
Member Author

@achekulaev per http://nodejs.org/

8.11.2 LTS
Recommended For Most Users
 
10.3.0 Current
Latest Features

@lmakarov

lmakarov commented Jun 1, 2018

Copy link
Copy Markdown
Member Author

8.11.0 is the nodejs version we currently have in cli (master)

@lmakarov lmakarov deleted the feature/cloud9 branch July 7, 2018 04:28
@lmakarov lmakarov mentioned this pull request Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants