Skip to content

Update pull request template with security section#5289

Merged
coverbeck merged 1 commit intodevelopfrom
feature/SEAB-5077/security
Dec 21, 2022
Merged

Update pull request template with security section#5289
coverbeck merged 1 commit intodevelopfrom
feature/SEAB-5077/security

Conversation

@coverbeck
Copy link
Copy Markdown
Collaborator

@coverbeck coverbeck commented Dec 20, 2022

Description
Update pull request template with security header

Review Instructions
When you create a PR, you should see a security header.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5077

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@coverbeck coverbeck self-assigned this Dec 20, 2022
@coverbeck coverbeck force-pushed the feature/SEAB-5077/security branch from 4d19395 to d662198 Compare December 20, 2022 22:33
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 21, 2022

Codecov Report

Base: 73.54% // Head: 73.53% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d662198) compared to base (fa76e2a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5289      +/-   ##
=============================================
- Coverage      73.54%   73.53%   -0.02%     
+ Complexity      4471     4469       -2     
=============================================
  Files            296      296              
  Lines          16914    16914              
  Branches        1862     1862              
=============================================
- Hits           12440    12438       -2     
  Misses          3590     3590              
- Partials         884      886       +2     
Flag Coverage Δ
bitbuckettests 28.33% <ø> (ø)
integrationtests 58.34% <ø> (-0.02%) ⬇️
languageparsingtests 10.83% <ø> (ø)
toolintegrationtests 30.48% <ø> (ø)
unit-tests_and_non-confidential-tests 27.16% <ø> (ø)
workflowintegrationtests 40.67% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...store/webservice/resources/DockerRepoResource.java 77.24% <0.00%> (-0.23%) ⬇️
...ckstore/webservice/resources/WorkflowResource.java 71.07% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coverbeck coverbeck merged commit 69e32cb into develop Dec 21, 2022
@coverbeck coverbeck deleted the feature/SEAB-5077/security branch December 21, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants