SEAB-6405: Fix date/folder formatting for github app delivery bucket #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-yuen
reviewed
May 2, 2024
coverbeck
reviewed
May 2, 2024
upsertGitHubTag/deployment/index.js
Outdated
| -${uploadDate.getDate()}/${deliveryId}`; //formats path to YYYY-MM-DD/deliveryid | ||
| const bucketPath = | ||
| `${uploadDate.getFullYear()}` + | ||
| `-${uploadDate.getMonth() + 1}` + |
There was a problem hiding this comment.
It would be nice if the length were always the same, e.g., 2024-05-02 instead of 2024-5-2. It was like this, but I only noticed it now.
There was a problem hiding this comment.
Screenshot updated :)
denis-yuen
approved these changes
May 2, 2024
coverbeck
approved these changes
May 2, 2024
kathy-t
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The folder names were messed up in the new s3 github delivery bucket because of the linter formatting.
Before:
After:
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6405
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!