Skip to content

SEAB-6405: Fix date/folder formatting for github app delivery bucket #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 3, 2024
Merged

SEAB-6405: Fix date/folder formatting for github app delivery bucket #164

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
803829e
fix
hyunnaye May 2, 2024
9f2c7be
eslint
hyunnaye May 2, 2024
1809ec9
eslint
hyunnaye May 2, 2024
76ed7a8
review feedback
hyunnaye May 2, 2024
75aa9f9
review feedback
hyunnaye May 2, 2024
4c1e6a5
review feedback
hyunnaye May 2, 2024
76c6e24
oops
hyunnaye May 2, 2024
c05d328
lint
hyunnaye May 2, 2024
fae755b
padstart
hyunnaye May 3, 2024
f6e708e
padstart
hyunnaye May 3, 2024
54596bf
padstart
hyunnaye May 3, 2024
1de63ed
padstart
hyunnaye May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions upsertGitHubTag/deployment/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,11 @@ function processEvent(event, callback) {
function logPayloadToS3(body, deliveryId) {
// If bucket name is not null (had to put this for the integration test)
if (process.env.BUCKET_NAME) {
const uploadDate = new Date();
const bucketPath = `${uploadDate.getFullYear()}
-${uploadDate.getMonth() + 1}
-${uploadDate.getDate()}/${deliveryId}`; //formats path to YYYY-MM-DD/deliveryid
const date = new Date();
const uploadYear = date.getFullYear();
const uploadMonth = (date.getMonth() + 1).toString().padStart(2, "0"); // ex. get 05 instead of 5 for May
const uploadDate = date.getDate().toString().padStart(2, "0"); // ex. get 05 instead of 5 for the 5th date
const bucketPath = `${uploadYear}-${uploadMonth}-${uploadDate}/${deliveryId}`;

const command = new PutObjectCommand({
Bucket: process.env.BUCKET_NAME,
Expand Down