Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the .github/workflows/review.yml “Review” workflow to make reviewdog-based linters fail the GitHub Actions job based on a configured threshold, rather than only reporting annotations.
Changes:
- Added
fail_level: errorto multiple reviewdog steps (misspell, hadolint, yamllint, actionlint, shellcheck). - Added
fail_on_error: "true"to the (currently disabled)reviewdog/action-shfmtstep.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: reviewdog/action-yamllint@v1 | ||
| with: | ||
| level: warning | ||
| fail_level: error |
| uses: reviewdog/action-shellcheck@v1 | ||
| with: | ||
| level: warning | ||
| fail_level: error |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -55,13 +58,15 @@ jobs: | |||
| if: false | |||
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
constant expression "false" in condition. remove the if: section [if-cond]
Comment on lines
23
to
26
| locale: "US" | ||
| level: warning | ||
| fail_level: error | ||
| pattern: | |
Comment on lines
34
to
37
| with: | ||
| level: warning | ||
| fail_level: error | ||
| reporter: github-pr-review |
Comment on lines
42
to
46
| uses: reviewdog/action-yamllint@v1 | ||
| with: | ||
| level: warning | ||
| fail_level: error | ||
| reporter: github-pr-review |
Comment on lines
67
to
70
| with: | ||
| level: warning | ||
| fail_level: error | ||
| reporter: github-pr-review |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.