last four mandatory and check bogus repetition #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pdpol
commented
Dec 4, 2019
pdpol
commented
- Make sure the last 4 digits are not optional, so anything under 8 digits doesn't process as valid
- Don't let an entire string of repeating digits go through as valid
|
Hi @pdpol! Thanks so much for the contribution, this looks awesome, let me take a look and I will merge this ASAP! |
|
You know what @pdpol, this PR is so good that I have added you as a maintainer to this package, best PR I have ever received! |
stuyam
deleted the
201912_phone_validate_repeating_digits_remove_optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.