chore: Refactor docling-eval to improve the overall codebase structure #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` dir. Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
…e in appropriate locations Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
PeterStaar-IBM
approved these changes
Feb 24, 2025
…ere functions from benchmarks/utils.py Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
…sets Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
nikos-livathinos
force-pushed
the
nli/package_refactoring
branch
from
adff951 to
2d5ea4e
Compare
Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
nikos-livathinos
force-pushed
the
nli/package_refactoring
branch
from
3e1dac6 to
4732ae2
Compare
- Move converters/teds.py into evaluators/teds.py - Move all functions from converters/utils.py into benchmarks/utils.py. - Rename create_xxx_converter() functions. - Rename BenchMarkColumns.DOCLING_VERSION as BenchMarkColumns.CONVERTER_VERSION Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com>
samiuc
pushed a commit
that referenced
this pull request
Mar 17, 2025
…36) * chore: Rename `docling/` dir as converters. Introduce `visualization/` dir. Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> * chore: Remove unused imports and other code formatting Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> * chore: Remove the `utils/` dir, delete unused files and move used code in appropriate locations Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> * chore: Introduce the file visualisation/visualisations.py and move there functions from benchmarks/utils.py Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> * chore: Update MyPy configuration in toml to override tqdm module Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> * chore: Clean up commented code Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> * chore: Add CONVERTER_TYPE and MODALITIES columns to all produced datasets Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> * chore: Update pinning of docling Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> * fix: Code refactoring: - Move converters/teds.py into evaluators/teds.py - Move all functions from converters/utils.py into benchmarks/utils.py. - Rename create_xxx_converter() functions. - Rename BenchMarkColumns.DOCLING_VERSION as BenchMarkColumns.CONVERTER_VERSION Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> --------- Signed-off-by: Nikos Livathinos <nli@zurich.ibm.com> Signed-off-by: samiullahchattha <Sami.Ullah1@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the guidelines from #35