fix: Cache same pipeline class with different options #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing caching same class with different options by using composite key (class, options) # TODO this will ignore if different options have been defined for the same pipeline class. at row 292 Signed-off-by: mislavmartinic <mislav.martinic@pontistechnology.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
mislavmartinic
changed the title
cau-git
reviewed
Mar 17, 2025
Member
cau-git
left a comment
cau-git
left a comment
There was a problem hiding this comment.
@mislavmartinic Many thanks for taking care of this flaw! Only one question below.
cau-git
previously approved these changes
Mar 24, 2025
cau-git
changed the title
Member
|
LGTM! |
Member
|
@mislavmartinic Many thanks. To pass the CI checks, can you please run the pre-commit toolchain and make another commit? |
Contributor
Author
What has been requested is done. |
ClemDoum
pushed a commit
to ClemDoum/docling
that referenced
this pull request
Mar 26, 2025
…ling-project#1152) * Update document_converter.py Fixing caching same class with different options by using composite key (class, options) # TODO this will ignore if different options have been defined for the same pipeline class. at row 292 Signed-off-by: mislavmartinic <mislav.martinic@pontistechnology.com> * formatted script * removed unnecessary hasattr check * pre-commit chain run --------- Signed-off-by: mislavmartinic <mislav.martinic@pontistechnology.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing caching same class with different options by using composite key (class, options)
TODO this will ignore if different options have been defined for the same pipeline class.
at row 292
Checklist: