fix: Edit bbox to to_bounding_box in PdfTextCell #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
hl2311
changed the title
Member
|
@hl2311 many thanks! This just needs two more steps...
Then make a new commit with the styling fixes. Important: Always commit with signoff ( |
Signed-off-by: hl2311 <dhlong2301@gmail.com>
Signed-off-by: hl2311 <dhlong2301@gmail.com>
Signed-off-by: hl2311 <dhlong2301@gmail.com>
fix: Refactor missing bbox attribute to PdfTextCell
cau-git
approved these changes
Mar 25, 2025
ClemDoum
pushed a commit
to ClemDoum/docling
that referenced
this pull request
Mar 26, 2025
…roject#1220) * Fix: Add missing bbox attribute to PdfTextCell * Fix: Add missing bbox attribute to PdfTextCell Signed-off-by: hl2311 <dhlong2301@gmail.com> * fix: Refactor missing bbox attribute to PdfTextCell Signed-off-by: hl2311 <dhlong2301@gmail.com> * Signed-off-by: hl2311 <dhlong2301@gmail.com> fix: Refactor missing bbox attribute to PdfTextCell --------- Signed-off-by: hl2311 <dhlong2301@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Resolved #1219 issue.
Discovered that the
PdfTextCellobject was missing thebboxattribute/method during testing of the batch conversion functionality within the examples.Resolution:
bboxtoto_bounding_boxand changed the code of line 66 in models\page_preprocessing_model.py file.Checklist: