-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(msword): support inherited numPr and multi-level numbering markers #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ DCO Check Passed Thanks @wantbook-book, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, akai <2780896955@qq.com>, hereby add my Signed-off-by to this commit: 7adf1ad I, akai <2780896955@qq.com>, hereby add my Signed-off-by to this commit: 74fb841 I, akai <2780896955@qq.com>, hereby add my Signed-off-by to this commit: a3a58bf I, akai <2780896955@qq.com>, hereby add my Signed-off-by to this commit: 3e564bf I, akai <2780896955@qq.com>, hereby add my Signed-off-by to this commit: 7deeb85 Signed-off-by: akai <2780896955@qq.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Thanks @wantbook-book for suggesting this fix. |
Issue resolved by this Pull Request:
Resolves #2758
Description:
w:numPrwhen it is not directly on the paragraph.numbering.xmlto render multi-level markers based onlvlText/start/numFmt, instead of flattening to single-level counters.lvlText(e.g.,%1.), so existing groundtruth likelist_after_num_headers.docxmay need updates.Checklist:
Tests:
pytest test_docx_numbering.py -q