Skip to content

Conversation

@sy-records
Copy link
Member

Summary

Related issue, if any:

Fix #2623

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docsify-preview Ready Ready Preview Comment Nov 7, 2025 4:08am

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the blockquote compiler by removing unnecessary code and simplifying the return statement. The changes improve code cleanliness without altering functionality.

  • Removed logic for filtering empty paragraphs from blockquote tokens
  • Simplified the return statement by eliminating an intermediate variable
Comments suppressed due to low confidence (1)

src/core/render/compiler/blockquote.js:1

  • The removal of the empty paragraph filtering logic should be verified with test coverage to ensure this doesn't introduce regressions in blockquote rendering, particularly for callout blocks with empty leading paragraphs.
export const blockquoteCompiler = ({ renderer }) =>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@paulhibbitts
Copy link
Collaborator

Thanks very much for taking a look at this @sy-records ! Unfortunately another minor issue has appeared with this fix, here is the updated Codebox:
https://codesandbox.io/p/sandbox/docsify-v5-template-multiline-github-callout-jk88fx

While the first line is now displayed, there seems to be an extra line now displayed before it. For example, with RC-3 notice the icon lines up with the first line of text:

Image

And with this fix now the icon is above the first line of text:

Image

Any ideas? Please let me know if more testing or info helps.
Paul
ps - I also have tested the same markup on GitHub: https://github.com/paulhibbitts/markdown-file-examples/blob/main/callouts.md and my original workaround of an extra line caused no issues so that is still an option if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected missing line with multiline GitHub Callout [v5 Rc-3]

3 participants