-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix: improve word breaking for code blocks in markdown #2636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sy-records is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses issue #2635 by adding word-break: break-word to inline code blocks and samp elements to improve text wrapping behavior in markdown content, preventing overflow issues with long unbroken text in code elements.
Key changes:
- Added
word-break: break-wordCSS property tocodeandsampelements in markdown styling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Thanks very much @sy-records ! I've made a sandbox to test with issue codeblock and additional examples: Things look good, but there does not seem to be a deployment with the most recent changes for me to Approve? |
|
I've reapproved it. Not sure why Vercel suddenly requires approval to build. |
paulhibbitts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated deployment @sy-records . I re-tested the new build in codesandbox on desktop and mobile and all looks good:
https://sd3x9g.csb.app/#/
Summary
Related issue, if any:
Fix #2635
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: